Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): Move profile config to workspace #10307

Merged
merged 2 commits into from
Aug 4, 2023
Merged

chore(cli): Move profile config to workspace #10307

merged 2 commits into from
Aug 4, 2023

Conversation

stinodego
Copy link
Member

Any cargo build in the workspace would result in the following warning:

warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /home/stijn/code/polars/polars-cli/Cargo.toml
workspace: /home/stijn/code/polars/Cargo.toml

So the profile config wasn't doing anything. Moving the profile definition to the workspace fixes the warning. However, the lto and panick keys are not supported. See rust-lang/cargo#9330

For now, this at least enables the strip option and removes the warning.

@universalmind303 Do you have any input here?

@github-actions github-actions bot added cli internal An internal refactor or improvement labels Aug 4, 2023
universalmind303
universalmind303 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me

@stinodego stinodego merged commit d9ff23c into main Aug 4, 2023
22 checks passed
@stinodego stinodego deleted the disable-profile branch August 4, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@universalmind303 universalmind303 universalmind303 approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stinodego @universalmind303